AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
335 stars 149 forks source link

ticket-2563: Linking the VBN stim and trials tables #2572

Closed morriscb closed 1 year ago

corbennett commented 1 year ago

We do want to copy the trial ids to the passive block. This makes answering questions like 'how do visual responses on hit trials compare to visual responses to the same stimuli during the passive block' easier.

morriscb commented 1 year ago

Hey @corbennett, so to be clear and confirm, we are not worried about potential misinterpretations of the trials when merged into the passive block in this way? That is someone thinking that there are, for instance, licks and similar events that happened during the passive block.

morriscb commented 1 year ago

Hey, updated the logic a bit for clarity. The implementation is obviously not going to be as efficient but I'll take the hit for clarity and expect that efficiency isn't a show stopper here.