AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
335 stars 149 forks source link

Ticket-2524: corrected_fluorescence_traces to represent neuropil_corrected_trace instead of demixed_trace #2584

Closed mikejhuang closed 1 year ago

mikejhuang commented 1 year ago

Changes made

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

morriscb commented 1 year ago

Okay, we can get everything loaded for r RMSE on the next ticket. One thing though, make sure to fix the linting on the test_cell_specimens.py file. I'll fix up the rest which we inherited from a while ago (no idea why they just recently showed up).

danielsf commented 1 year ago

@morriscb

"(no idea why they just recently showed up)"

To save ourselves a lot of agonizing work, the SDK CI was configured so that linting is only run on files when they are touched. We adopted PEP8 very late in the game and did not have the time to fix every file in the SDK. Thus, anyone unfortunate enough to have to touch ancient code gets hit with a bunch of linter errors that aren't their fault.

Just wanted to make sure you had that context.

aamster commented 1 year ago

@morriscb I fixed that in main so that I could deploy an internal module

I think you have to merge master into the release branch to make that go away.

morriscb commented 1 year ago

I think we can consider the adding the demix as an "addition" right now we are fixing the logic to return the correct data. Adding additional traces (which demix will be) is another issue.