search

AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
333 stars 149 forks source link

Revert optional traces logic once VBO updated data released #2632

Open aamster opened 1 year ago

aamster commented 1 year ago

Revert https://github.com/AllenInstitute/AllenSDK/pull/2630/commits/9d65b58430a0846d6609fc48323d39b2b1121fbb once updated VBO data has been released.

morriscb commented 1 year ago

We shouldn't do this fully as it will cause incompatibility with the previously released data. We can clean up around this code and document that this is for backwards compatibility or NWBs that were not produced with these datasets. This also applies to the average imaging depth calculation values as the code will crash if the value is not found and the try/except return is not there.