search

AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
343 stars 149 forks source link

VBN NWB files need to be updated to reflect LFP data release #2641

Open corbennett opened 1 year ago

corbennett commented 1 year ago

Describe the bug Now that the LFP data has been released for VBN, the probes table in the session object should accurately reflect which probe insertions had valid LFP data. Currently, they don't have any LFP info (though the VBN cache probes metadata table does).

To Reproduce Steps to reproduce the behavior. Please include all relevant code!

#grab a vbn session with LFP data
session = cache.get_ecephys_session(
            ecephys_session_id=1064644573)

#look at the probes table
session.probes

#compare to the metadata probes table filtered for this experiment
probes = cache.get_probe_table()
probes[probes['ecephys_session_id']==1064644573]

The lfp_sampling_rate and the has_lfp_data columns for these two tables should be identical. But we haven't updated the NWB files to reflect the LFP data, and so the session.probes table lacks info about LFP.

Expected behavior The lfp_sampling_rate and the has_lfp_data columns for the session.probes table and the cache probes table should be identical.

Actual Behavior The session.probes table hasn't been updated to include info about the LFP data. (NaNs for lfp_sampling_rate and False for has_lfp_data)

Environment (please complete the following information):

Do you want to work on this issue? Happy to help.