AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
333 stars 149 forks source link

Ticket/PSB-13: Pika validation of VBO data release #2658

Closed morriscb closed 1 year ago

morriscb commented 1 year ago

Multiple changes to NWB and metadata creation/loading for updated VBO release

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

morriscb commented 1 year ago

Hey @aamster, I'm wrapping up your review and wanted to run by what I think the plan will be. First, move the behavior nwb writer to a folder write_nwb and the move the ophys writer to ophys/write_nwb both under behavior. I'll move the two schemas for Ophys and Behavior to nearer the metadata table creation as suggested. I'll also move the _compare_metadata function to near the nwb_utils. Sound good?

aamster commented 1 year ago

@morriscb that plan sounds good.