search

AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
344 stars 149 forks source link

ticket/PSB-91: Add trials_id calculation to BehaviorSession creation. #2668

Closed morriscb closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

morriscb commented 1 year ago

In addition, a test is failing because trials is not passed

Forgot to add a check for if the input Trials is None.

aamster commented 1 year ago

Can you please describe the purpose of this PR. What is the problem with adding the trial_id on the fly as it is now?

morriscb commented 1 year ago

Can you please describe the purpose of this PR. What is the problem with adding the trial_id on the fly as it is now?

Do you mean changing the name/description of the ticket to better describe it or describe it here to your now?

aamster commented 1 year ago

adding it to the description could help

morriscb commented 1 year ago

adding it to the description could help

Updated the description on JIRA.