Psb 127/mouse connectivity cache bugfix

AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data

https://allensdk.readthedocs.io/en/latest/

Other

333 stars 149 forks source link

Psb 127/mouse connectivity cache bugfix #2700

Closed mikejhuang closed 11 months ago

mikejhuang commented 11 months ago

https://github.com/AllenInstitute/AllenSDK/issues/2685

Implemented the suggested fix by Lydia Ng.

Switched primary_injection_structure to structure_id rather than the first structure in the list of injections

review-notebook-app[bot] commented 11 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mikejhuang commented 11 months ago

Can you please fix the linting that's failing? Currently got a fix to the failing 3.10 tests on #2698 in the two requirements files. You can either pull them in to fix the failures or wait till I merge that PR.

Yes, my understanding is that we agreed that linting fixes will be done after the PR review is completed.