Ticket/psb-171: Various fixes for VBO release

AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data

https://allensdk.readthedocs.io/en/latest/

Other

333 stars 149 forks source link

Ticket/psb-171: Various fixes for VBO release #2707

Closed morriscb closed 10 months ago

morriscb commented 11 months ago

Add additional doc to experiment level cell specimen return.
Change to Int64 to have N/A values in the metadata table instead of -99 as requested. Modify enforce_df_int_typing to return Int64 types.
Change stimulus table name from repeat to movie_repeat
Modify location of spurious omitted stimulus check and move code to static_method function. Fixes incorrect detection of 5 minute grey screen.
Update unittests and test data.

review-notebook-app[bot] commented 11 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

morriscb commented 10 months ago

Dropping the "max_correction" values ended up breaking unittests in a non-trivial way so I ended up not doing it after approval from Marina as dropping the columns is not strictly necessary or fixing any bug.