Closed mikejhuang closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
I intended to consolidate the dependencies in pyproject.toml and remove the requirements.txt after I understood it better when reading about it more and discussing it with the rest of the team.
I renamed this PR from "Poetry dependency manager" to "Resolve dependencies refresh" since the Poetry aspect was a tool used to build the pyproject.toml but is not a requirement for this package. I believe it would be up to each developer to use Poetry if they believe it adds value to the way they manage dependencies. You can still manually edit the versions in the pyproject.toml file and use pip if you don't want Poetry to define them for you.
I believe it would be up to each developer to use Poetry if they believe it adds value to the way they manage dependencies.
I am not going to adopt poetry right now. That leaves Chris. @morriscb will you be adopting poetry for development? If the majority of developers are not going to adopt it, then let's remove pyproject.toml, poetry.lock, etc from this PR.
I believe it would be up to each developer to use Poetry if they believe it adds value to the way they manage dependencies.
I am not going to adopt poetry right now. That leaves Chris. @morriscb will you be adopting poetry for development? If the majority of developers are not going to adopt it, then let's remove pyproject.toml, poetry.lock, etc from this PR.
I do not plan to adopt poetry at this time, no.
This should be trageted onto branch rc/2.16.0.
I recall agreeing that it should be targeted to main to expedite this so that users of SWDB would have these changes.
The fix for SWDB has already been deployed and is working. That was the tickets we were referring to, not tihs one.
The fix for SWDB has already been deployed and is working. That was the tickets we were referring to, not tihs one.
I recall it was also for this one since it would reduce the compatibility issues users might run into during that workshop.
Include Python 3.11 compatibility, unpeg all dependencies and fix breaking changes from updated packages or downgrade packages.
Steps
python = ">=3.8,<3.12"
poetry_py38-311.txt
poetry.lock
file stores the actual installed versions for reproducibilityFixes for compatibility
Int64Index
deprecated https://github.com/pandas-dev/pandas/issues/42717pd.Series.str.replace
must specifyregex=True
if regex is used.pd.Series.reindex
with aMultiIndex
can no longer take in single integer Index as an inputcheck_less_precise
is a deprecated parameter inpd.testing.assert_series_equal
. This is replaced withr_tol
anda_tol
Reverting versions instead of fixing
VisualBehaviorProjectCache.get_ophys_session_table( index_column="ophys_experiment_id").index
is type'object'
, expectedint64
All the values in this index are int64 so I'm not sure why it was loaded as an object type.