ticket/PSB-257: Investigate AllenSDK test failure for python3.9

AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data

https://allensdk.readthedocs.io/en/latest/

Other

333 stars 149 forks source link

ticket/PSB-257: Investigate AllenSDK test failure for python3.9 #2729

Closed morriscb closed 8 months ago

morriscb commented 8 months ago

Explicitly set xarray coordinates.

review-notebook-app[bot] commented 8 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mikejhuang commented 8 months ago

Can you rerun the failed Python 3.9 tests on bamboo before merging into rc/2.16.0?

If so, please link to the tests here. If not, how did you verify this resolved the issues?

morriscb commented 8 months ago

Ran the test with python3.9 in a fresh conda environment on Linux. Was able to reproduce the issue from the bamboo test. Once I applied the fix shown here, the tests passed. The code change on this ticket produces the same output data, it is just more explicit in the manipulation of the xarray.

The tests on bamboo are unfortunately only set up for master and rc branches. I quickly checked again just now and there wasn't an obvious way to trigger the test on a specific branch.