search

AllenInstitute / MOp_taxonomies_ontology

Central location for versioning and sharing of taxonomy files relevant for ontology development as part of cell type cards.
Other
2 stars 0 forks source link

Removed Neurogliaform Cell Label #4

Closed shawntanzk closed 3 years ago

shawntanzk commented 3 years ago

see discussion in https://github.com/obophenotype/brain_data_standards_ontologies/issues/156

shawntanzk commented 3 years ago

I have also changed cell_set_additional_alias to cell_set_addtional_aliases according to the spec here: https://github.com/obophenotype/brain_data_standards_ontologies/blob/master/doc/dendrogram_spec.md Not sure where the spec came from but might be easier to just follow that

raymond-sanchez commented 3 years ago

Just reviewed the discussion above and referred back to our previous conversation about this @shawntanzk - if removing the NGC label simplifies things then that's fine by me. Also I think changing "alias" -> "aliases" in the nomenclature is fine (and more accurate in many instances) but Jeremy can weigh in if not!

jeremymiller commented 3 years ago

I'm fine with all of that. Likely the alias vs. aliases was an error I introduced by manually typing it. I don't feel strongly either way.

shawntanzk commented 3 years ago

brilliant will merge it in then, thanks :)