Open mdylan2 opened 4 years ago
First of all, by default, we are using [1.0, 1.0, 1.0] spacing in our segmentation algorithms even though our images are not isotropic. In practice, in our images (ZYX = 0.29 x 0.108 x 0.108 micron), I find that results obtained by isotropic spacing, i.e. [1, 1, 1], are usually more consistent with what I expect intuitively, than using the true image spacing. So, we decide to make the wrapper without requiring users to set the spacing and use [1.0, 1.0, 1.0] by default.
Technically, the issue you pointed out is true, where users can change the spacing if they need. I will fix it in the next release.
Edge preserving smoothing in 3D depends on voxel spacing. Below is the code you currently have for![image](https://user-images.githubusercontent.com/47123837/76118228-6ff3e780-5fbb-11ea-86c0-4391e9d8e958.png)
edge_preserving_smoothing_3d
underaicssegmentation/core/pre_processing_utils
.Rather, this is what I think should be incorporated:![image](https://user-images.githubusercontent.com/47123837/76118272-839f4e00-5fbb-11ea-8d5e-8c4595f8a22c.png)
What are your thoughts?