AllenInstitute / biofile-finder

An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
https://biofile-finder.allencell.org/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Enable Multiple Data Sources #109

Closed SeanLeRoy closed 5 months ago

SeanLeRoy commented 6 months ago

Description This changeset enables users to select more than one data source in a single query. This is largely a proof-of-concept implementation of this feature as I think we could spend more time to make this much more performant like by perhaps creating views that are representations of a query's data sources.

How to review Most of the changes to look for are in the SQLBuilder & logics.tsx

Testing Tested on desktop and in the web adding various types of data source combination and performing queries.

BrianWhitneyAI commented 6 months ago

image Seeing this when trying to load in various datasets locally.

fro variance set

:9001/?source=%7B%22…ri%22%3A%7B%7D%7D:1 Uncaught (in promise) Catalog Error: Table with name Variance Paper Dataset does not exist!
Did you mean "pg_database"?
LINE 4:             FROM "Variance Paper Dataset"

And this for the second dataset

localhost/:1 Uncaught (in promise) Catalog Error: Table with name AIND Image Atlas - AIND Image Atlas does not exist!
Did you mean "pg_settings"?
LINE 4:             FROM "AIND Image Atlas - AIND Image Atlas"
aswallace commented 5 months ago

I'm now able to select, filter, group on multiple data sources, both web and desktop. Still having issues with downloading manifests: Web:

Desktop:

SeanLeRoy commented 5 months ago

I'm now able to select, filter, group on multiple data sources, both web and desktop. Still having issues with downloading manifests: Web:

  • I can download successfully for non AICS sources, but when I try to download from AICS source it claims to download successfully, but then the browser gives me a "File wasn't available on site" error and doesn't actually complete the download This was an issue with the type I was sending to the databaseservice, should work now.

Desktop:

  • Still having the header issue with downloading CSVs Added option "HEADER" to CSV exports, should work

  • I'm still seeing the error Brian mentioned when it tries to reload an external data source, and the modal + error won't go away even if I select a new file Fixed, the cache of annotations was saving [] as a valid list of annotations, seems to be working now

This should all be fixed now.

aswallace commented 5 months ago

This should all be fixed now.

Confirmed that these fixes all worked for me! Only running into a couple small issues now:

Also two future feature requests: