search

AllenInstitute / biofile-finder

An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
https://biofile-finder.allencell.org/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

quick update for "open with agave" protocol #231

Closed toloudis closed 2 months ago

toloudis commented 2 months ago

https://github.com/AllenInstitute/biofile-finder/blob/3f0a848de2737bd83b17ad5203bacc64cfe83e97/packages/core/hooks/useOpenWithMenuItems/index.tsx#L113

I'd like the new agave href to be agave://?url=${fileDetails?.path} to fix a bug with the way macOS handled the url.

If you notice in this screenshot, there is no : character after the https. This is because the url is being misinterpreted before it even gets into AGAVE. Using a query string completely fixes this. There will be a corresponding update to AGAVE to deal with this too.
Screen Shot 2024-09-05 at 1 25 54 PM

toloudis commented 2 months ago

New agave build with the new url protocol handling will be here: https://github.com/allen-cell-animated/agave/actions/runs/10739707159