search

AllenInstitute / biofile-finder

An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
https://biofile-finder.allencell.org/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Finish Integrating Multi-Data Source Feature + Revamp Style #79

Closed SeanLeRoy closed 6 months ago

SeanLeRoy commented 7 months ago

Description of Change This change is intended to be part II of enabling the explorer to read from a various data sources (CSVs, JSON, Parquet) - in this section I am largely just doing cosmetic changes or trying to improve/consolidate relevant code. Specifically what has happened is the "Annotation Sidebar/Hierarchy", "Filter bar", "Header", and "URL bar" have all been consolidated into the "QuerySidebar". This is beneficial by localizing interactions regarding an individiual query + removes app specific language like "Annotation Hierarchy" in favor "Group", "Filter", & "Sort". It enables us to allow users to have multiple queries that they can switch to.

How to Review I am happy to go through this changeset with anyone, but for your own browsing:

Tons of this changeset is applying style changes / moving components around visually with the same functionality as it had before hence tons of deleting code and .css changes. I'd consider focusing on /entity/ files then the /components/<file_name>.tsx files.

Testing Tons of testing by manually going through each of the features in the desktop run version of the application + adding / modifying various unit tests. Please let me know if you see tests you'd like or encounter a bad UX!

Before

Screen Shot 2024-04-24 at 11 23 06 AM

After new-gif

aswallace commented 7 months ago

Running into an issue with column selection/persistence that I don't remember seeing on the original PR so might be an introduced bug? Currently doesn't allow me to deselect columns that were already present on app load, which also means I can have a column present multiple times w/o being able to get rid of it

Screenshot 2024-04-25 at 10 24 32 AM
BrianWhitneyAI commented 7 months ago

I noticed when trying to rebase onto this branch that I was having trouble reloading the page. Additionally I did not seeing any change in appstate for HAS_USED_APPLICATION_BEFORE always being set to false. Could be just a local issue but thought I would mention it.

SeanLeRoy commented 7 months ago

https://github.com/AllenInstitute/aics-fms-file-explorer-app/pull/79#issuecomment-2077797171

Fixed in 638549f

SeanLeRoy commented 7 months ago

https://github.com/AllenInstitute/aics-fms-file-explorer-app/pull/79#issuecomment-2091145504

Not able to reproduce this, lmk if you keep seeing this and we can hop on a call and check it out