search

AllenInstitute / bmtk

Brain Modeling Toolkit
https://alleninstitute.github.io/bmtk/
BSD 3-Clause "New" or "Revised" License
265 stars 86 forks source link

"TwoSubfieldLinearCell" saves the dominant_filter amplitude for nondominant_filter unit #337

Open CloudyDory opened 10 months ago

CloudyDory commented 10 months ago

In line 57-60 of bmtk/simulator/filternet/lgnmodel/cellmodel.py, the dominant_unit and nondominant_unit are created as:

self.dominant_unit = LNUnit(self.dominant_filter, ScalarTransferFunction('s'),
                                    amplitude=self.dominant_filter.amplitude)
self.nondominant_unit = LNUnit(self.nondominant_filter, ScalarTransferFunction('s'),
                               amplitude=self.dominant_filter.amplitude)

This looks strange to me, as the nondominant_unit should save the amplitude as self.nondominant_filter.amplitude.