AllenInstitute / bmtk

Brain Modeling Toolkit
https://alleninstitute.github.io/bmtk/
BSD 3-Clause "New" or "Revised" License
275 stars 89 forks source link

Adding overwrite_config option to build_env_pointnet() and merging 2024 bmtk-workshop opt tutorials #386

Open beaherrera opened 1 month ago

beaherrera commented 1 month ago
kaeldai commented 1 month ago

Hi @beaherrera, I noticed that in the changes you made to the sim_setup.py and conf.py all seem to have changed single quotes (') to double quotes (").

Python doesn't make the distinction between the two, and I personally don't have any hard-and-fast rule on when and how which quotes to use (although I tend to prefer single quotes myself). Is it possible this was something changed by your IDE? If so you will want to disable that because, besides making it hard to look at changes, if you aren't careful automatically changing quote styles can cause other issues.

beaherrera commented 1 month ago

Hi @kaeldai,

Thank you for reviewing the PR! I'm sorry about that. It’s the auto formatter I use. I’ll fix the commit. I just changed a few lines, which are hard to see among all the changes.

Best, Beatriz

beaherrera commented 1 month ago

Hi @kaeldai,

I reverted the commit and removed the auto string normalization. You can see the changes I made to build_env_pointnet() in my last commit 1698d2c

Thanks, Beatriz