AllenInstitute / brain_observatory_qc

Other
2 stars 0 forks source link

add dynamic thresholding depending upon metadata/configuration #247

Open shiellac opened 1 year ago

shiellac commented 1 year ago

I'd like add frame rate as a QC metric in the ophys session reports.

the frame rate, based on imaging configuration is project dependent. this could be an automated module.

we have had recent instances where sessions should have been marked as fail bc of incorrect frame rate/ ROI size but was not caught until downstream analysis. Also, to monitor if the frame rate changes for whatever reason during a project's timeline.

DowntonCrabby commented 1 year ago

@shiellac Frame rate currently is a qc metric in the ophys session reports- it's the "Mean Interframe Interval (s)" in the Data Stream Timing and Sync (Automated) module.

We can update the name to make it more intuitive- like "mean frame rate (s)" if you prefer. image

As for changing the threshold for frame rate on imaging configuration- I think that's a great idea. It will require some work to parse the metadata and have a threshold pre-calculated. We can add that as a feature request to one of the upcoming milestones.

I don't think we'll get to it immediately but soon!

DowntonCrabby commented 1 year ago

I'm going to update the naming of this issue to reflect the request for different pre-calculated thresholds if that's okay with you @shiellac

DowntonCrabby commented 1 year ago

I have updated the display name from interframe interval to frame rate image (14)

samiamseid commented 1 year ago

tossing this in a suggestion: if we expressed frame-rate in Hz, i think it would be a more easily communicated metric. Usually that is how we discuss it anyways.

matchings commented 9 months ago

@DowntonCrabby Is this done? seems like it, except maybe the last request from Sam to report it in Hz?