AllenInstitute / brain_observatory_qc

Other
2 stars 0 forks source link

Missing Images in QC Reports #269

Closed samiamseid closed 7 months ago

samiamseid commented 1 year ago

Describe the bug Occassionally, reports will have missing images. Most commonly, this is the Maximum Projection image in the experiment report, in the Field of View Quality and Motion Correction and Field of View Matching incomplete sections. Often this will only impact a subset of experiments within a session. These experiments will have completed processing and motion correction, so it is unclear why the images would continue to be missing.

Expected behavior Images such as Maximum Projection images should populate after motion correction finishes

Screenshots Two experiments from 1 session with missing max projection images. All 6 other planes loaded fine. http://mouse-seeks/qc/ophys/experiment/1272989329 http://mouse-seeks/qc/ophys/experiment/1272989330

I suspect this has something to do with when a QC module loads for the first time. Perhaps if it loads before motion correction finishes, it will not have the max projection image, and there is nothing that prompts the module to reload after motion correction is finished.

samiamseid commented 1 year ago

qc dev version has "Field of View Matching" with missing surface image http://qc-sys-webapp-dev/qc/ophys/experiment/1289149706

This appears to be true for all cases of experiment reports with this module.

matchings commented 9 months ago

@seanmcculloch Is this still an issue?

samiamseid commented 9 months ago

Yes we still have many reports generating without maximum projection images in particular. Unsure if this will be fixed in the mouse_qc_dev release, though i believe this issue has something to do with the report generating before LIMS has processed the max projection image for a given plane

seanmcculloch commented 7 months ago

This was due to changing where the metric was saved in the database. older records saved it at the session level, newer records save it under the experiment.

Changed the module to look for the metric at the session level, where it is present for all records.