AllenInstitute / brain_observatory_qc

Other
2 stars 0 forks source link

Dev QC Modules with "Flags" default as collapsed #295

Open samiamseid opened 11 months ago

samiamseid commented 11 months ago

Describe the Issue In the Dev QC, certain modules are by default in the "collapsed" configuration, making it faster for operators to look through the report at important information.

Sections that are "information" only, such as Stimulus progression, Experiment Metadata, Session Metadata, Local Z Stack Filepaths and Z stack setup parameters this makes sense, as in most cases operators do not need to look at this information.

However, one unexpected way this new feature is showing up is that modules with any automatic flags get "collapsed" if there is something flagged. For example, this session has a flag in FIeld of View Quality and Motion Correction, and is collapsed when you open the report: http://qc-sys-webapp-dev/qc/ophys/experiment/1289149712

This is dangerous, as it hides key information. One purpose of the flags in the report should be to alert the QCer that something is abnormal, and that they should be taking a closer look, such as in the example above where the flag is indicating that the motion correction has failed (which it has)

Expected behavior Modules with flags should not default to collapsed. If a module is by default collapsed, it should open when a flag is present, not visa versa

Screen noflag shots yesflag