search

AllenInstitute / brain_observatory_qc

Other
2 stars 0 forks source link

Dev-QC: Move controlled language tag from FOV Integrity to Full Field Module #327

Closed arielleleon closed 4 months ago

arielleleon commented 10 months ago

Move the controlled language tag "field of view associated with incorrect area and/or depth" from Session Experiments FOV Integrity report module to Full Field report module

DowntonCrabby commented 6 months ago

@samiamseid @shiellac @seanmcculloch Can you give me a little more clarity on this ticket? Currently this controlled language tags exists in the session report because that is where all the experiment FOVs are shown in the same place- which should make it easier to identify when this issue occurs.

It sounds like you want this to be moved to one of the experiment report modules (though I'm not sure which one). Here's a list of the experiment reports sections, please let me know which one youd like me to move this controlled language tag to: image

DowntonCrabby commented 6 months ago

And here's where it currently exists (highlighted in yellow, with all the other session report sections- if you do want to keep it in session reports) image

samiamseid commented 6 months ago

I'm not actually sure what this ask is. Maybe Arielle remembers?

Best I can interpret is that this is assuming we would have a module for the stitched and registered fullfield image which is currently not in the qc system? Theoretically a fullfield report module would still be at the session level though.

seanmcculloch commented 4 months ago

closed: relevant duplicate https://github.com/AllenInstitute/brain_observatory_qc/issues/154