search

AllenInstitute / brain_observatory_qc

Other
2 stars 0 forks source link

qc module status change if metrics and/or plots missing #369

Closed DowntonCrabby closed 1 week ago

DowntonCrabby commented 9 months ago

Describe the bug The QC system currently provides a list of missing plots and metrics, however other critical information is not present. For example, can something be reprocessed to get the missing metrics? How do operators QC if metrics are missing?

Expected behavior Missing metrics and plots should be treated in the same way as when thresholds are violated- it should have an impact on the qc status of the module- and it should also be looked into as to why the metrics & plots are missing.

Scope This relates to all reports.

samiamseid commented 5 months ago

Something causing this feature to duplicate the fail tag multiple times a second duplication

samiamseid commented 5 months ago

Tested on session http://qc-sys-webapp-dev/qc/ophys/session/1346243082 and experiment http://qc-sys-webapp-dev/qc/ophys/session/1346243082

"Pass" could not be selected if metric is missing (this seems to be working as intended) QC verdict in session summary and in session log both accurately reflect failed status even if all other modules are marked passed (working as intended)

This feature looks ready to go

seanmcculloch commented 1 week ago

Pushed to mouse-qc on 9/23/24