paired plane, plane assignments not working as expected

DowntonCrabby commented 7 months ago

Describe the bug There seems to be a bug with how pairs of planes are being assigned to paired plane groups. I have seen examples where a single experiment FOV is listed in 2 different pairs, and where a single experiment makes up both components of a single pair.

Session ID: 1316180619 problematic pair(s): 3 impacted experiment ID(s): 1316301502

Session ID: 1315948257 problematic pair(s): 2 impacted experiment ID(s):1316081601

Expected behavior Paired planes should consist of 2 different FOVs with distinct experiment ids and these are not repeated between pairs

Scope Ids are listed above, I will add more as I find more

samiamseid commented 5 months ago

wrong2 wrongplane

Two additional examples found on the new QC system, showing that the experiment IDs and images do not always match. Example session IDs: http://mouse-qc/qc/ophys/session/1322874207 http://mouse-qc/qc/ophys/session/1316180619 http://mouse-qc/qc/ophys/session/1316158004 (actually it looks like this is happening in every session on the new mouse-qc system)

seanmcculloch commented 5 months ago

There was a race condition when filling in each of the rows and the data was getting mixed in an unpredictable way. This is now corrected and all reports i've checked show the module is loading properly. (including paired planes, exp. ID and related images)

Fixed in commit: https://github.com/AllenInstitute/qc-sys-webapp/pull/34/commits/481221f4c746f7c82facea1def0c280c76cbd608

merged to main

AllenInstitute / brain_observatory_qc

paired plane, plane assignments not working as expected #375