search

AllenInstitute / brain_observatory_qc

Other
2 stars 0 forks source link

Module Deployment Inconsistent Between Projects #399

Open samiamseid opened 4 months ago

samiamseid commented 4 months ago

Metric / Plot Impacted Different projects are supposed to have different modules depending on project needs (for example, only behavior projects need the behavior modules). However, currently there are key modules that belong in every project that are not consistently deployed across projects.

For example, LearningmFISHTask1A has "[Brain Health and Window Clarity]" but U01BFCT does not. I think we need to review all active projects and current modules and make sure the correct modules are being used.

Update Motivation A. We are currently missing important QC metrics in certain projects B. QC may not be consistent between projects if different versions of metrics are being deployed C. Analysis of historical QC values is less valid if certain projects are missing metrics

Requested Feature/Solution Review modules in active projects and make sure we are consistent

DowntonCrabby commented 4 months ago

In the case of missing the brain health and window clarity module- I have updated this in the dev instanced of the database: image

Here are the modules currently: image

samiamseid commented 3 months ago

I can confirm that these modules look correct as you have them listed! However, i notice that all of the sessions running active behavior are currently marked as "error" in dev-QC, and are missing behavior, task, and lick modules (though the session report itself does not say they are missing)

DowntonCrabby commented 3 months ago

Can you add a screenshot of this, Sam?

samiamseid commented 3 months ago

devqc devqc2

samiamseid commented 3 weeks ago

I just checked on some dev qc reports that generated back in mid may, and it looks like whatever was causing the issue i mentioned above is gone. Both active and passive project reports have the all the necessary modules