search

AllenInstitute / datacube

Other
0 stars 1 forks source link

please update warehouse host for env_vars.json and env-prod_vars.json to use $DATACUBE_DATA_SOURCE #32

Open shus2018 opened 6 years ago

shus2018 commented 6 years ago

streamline_lookup": "http://api.brain-map.org/api/v2/data/SectionDataSet/{0}.json", "reconstruction_lookup": "http://api.brain-map.org/api/v2/data/Specimen/{0}.json?include=neuron_reconstructions(well_known

Nice to use the CURRENT warehouse and data.

NileGraddis commented 6 years ago

@shus2018 I'm not familiar with these files, could you point me to them?

Also I'm not sure how the reconstructions fit in. Are those datacubed?

shus2018 commented 6 years ago

It is not datacubed but data was used by datacubes. :-)

You can find the two config files from service/locator/*.json

NileGraddis commented 6 years ago

Ok, so if I understand correctly you would like these to point at a variable location rather than being fixed to api.brain-map.org. Does that sound right?

If you have an idea of how you would like this to look, could you implement the changes (or put them in a code block here)?

shus2018 commented 6 years ago

We have $DATACUBE_DATA_SOURCE env variable already, just need to update fixed one to env variable, you should assign this to Chris. :-)

chrisbarber commented 6 years ago

https://github.com/AllenInstitute/datacube/blob/dev/services/locator/env_vars-prod.json#L2-L3

It would be nice to variable-ize these, I agree.