search

AllenInstitute / datacube

Other
0 stars 1 forks source link

force inclusion of seed in correlation search filters #75

Closed chrisbarber closed 6 years ago

NileGraddis commented 6 years ago

code looks good - testing on axon shortly

NileGraddis commented 6 years ago

looks good to me on axon.

chrisbarber commented 6 years ago

@NileGraddis thanks for testing

chrisbarber commented 6 years ago

@NileGraddis just to double check-- does running your conn bridge tests verify that your additional OR {"field": "experiment", "op": "=", "value": seed_idx} clause does not interfere with this?

NileGraddis commented 6 years ago

Yes. In some cases the r values have changed on the order of 10^-{4,5,6}, but I think that might be unavoidable - it could be caused by running sums in different orders for instance, which is the sort of thing we don't really have detailed control over when deferring to a backend like dask.

chrisbarber commented 6 years ago

This isn't using dask, just ndarrays. The parallelize decorator works on xarray but the chunks all end up being views on to the original ndarrays.