search

AllenInstitute / datacube

Other
0 stars 1 forks source link

clean up or templatize crossbar configs #90

Closed chrisbarber closed 5 years ago

chrisbarber commented 6 years ago

@shus2018 are you still using https://github.com/AllenInstitute/datacube/blob/dev/.crossbar/config-test.json ? Wondering if we can clean it up. Just thinking about #89 and how we have a bunch of configs with duplicated sections. @NileGraddis also has an additional config. Thinking we should either commit to only checking in configs that are strictly necessary, or just find a way to templatize configs so we don't have to worry about this.

We also have the standalone router config which duplicates some things.

@NileGraddis one approach to the "no bob" configuration that might be cleaner is to just set the dataset to "enabled": false. Currently this will still spin up an extra datacube which will say Server ready (). rather than Server ready (cell_specimens).. We could change the datacube loading logic to exit if there are no enabled datasets.

chrisbarber commented 5 years ago

I'm going to leave the router-only config for now; it is not as bothersome as the many configs in the ./.crossbar/ directory.