Test and validate VBN monitor_delay implementation

AllenInstitute / ecephys_etl_pipelines

Pipelines and modules for processing extracellular electrophysiology data

Other

1 stars 2 forks source link

Test and validate VBN monitor_delay implementation #20

Closed wbwakeman closed 2 years ago

wbwakeman commented 2 years ago

Follow up to #18, need to process test data and get people to review the outputs to confirm

Tasks:

Create validation data files
Process them with the new code
Provide outputs to key stakeholders (e.g. Nick, Corbett) for review
Address feedback

danielsf commented 2 years ago

I'd like to put in a specific call for unit tests to these methods trim_border_pulses correct_on_off_effects fix_unexpected_edges and flag_unexpected_edges

They seem very self-contained yet have interesting edge cases that we need to be handling correctly.

ns706 commented 2 years ago

I have run multiple validation files with the new code and have provided the outputs to Corbett. A few issues came up (see issues #25 and #24) which I have been addressed.

I've also fixed many of the broken tests. However, I could not fix all of them as a few are much more involved and cannot be easily fixed. A smaller version of a real experiment will probably be needed as a test fixture for these cases.