search

AllenInstitute / ecephys_etl_pipelines

Pipelines and modules for processing extracellular electrophysiology data
Other
1 stars 2 forks source link

Ecephy etl pipelines 18 #26

Closed ns706 closed 2 years ago

njmei commented 2 years ago

Can you update commit messages to be more descriptive? For example looking at the message in 59e84fc, I think a naive reviewer would want to know why those changes were made.

e.g. Why should only falling edges that occur after a rising edge be considered?

ns706 commented 2 years ago

Can you update commit messages to be more descriptive? For example looking at the message in 59e84fc, I think a naive reviewer would want to know why those changes were made.

e.g. Why should only falling edges that occur after a rising edge be considered?

Can you update commit messages to be more descriptive? For example looking at the message in 59e84fc, I think a naive reviewer would want to know why those changes were made.

e.g. Why should only falling edges that occur after a rising edge be considered?

I'll use more descriptive commit messages in the future. Thanks!