AllenInstitute / ecephys_spike_sorting

Modules for processing extracellular electrophysiology data from Neuropixels probes
Other
109 stars 91 forks source link

l_ratio #52

Closed bartulem closed 4 years ago

bartulem commented 4 years ago

Hi guys,

On line 700 in the metrics.py script from the quality_metrics module, you have "mahalanobis_other" in the denominator of the l_ratio metric. I was wondering if this was a mistake and if it should rather be "mahalanobis_self"?

jsiegle commented 4 years ago

Good catch! Normalizing by the number of within-cluster spikes is correct. I will make sure this gets fixed here, as well as in the spikemetrics repo.

jsiegle commented 4 years ago

Ok, fixed!

https://github.com/AllenInstitute/ecephys_spike_sorting/blob/d9d041e9e7d965d1e66fea0c213b4d0876be9e0e/ecephys_spike_sorting/modules/quality_metrics/metrics.py#L700-L701