AllenInstitute / ecephys_spike_sorting

Modules for processing extracellular electrophysiology data from Neuropixels probes
Other
109 stars 91 forks source link

Two more checks for PC metrics #53

Closed mmyros closed 4 years ago

mmyros commented 4 years ago

Not all labels are this cluster and No fewer than 20 spikes in this cluster

jsiegle commented 4 years ago

Looks good, thanks for updating the travis file!

mmyros commented 4 years ago

Oops sorry did not mean to pshh travis, since it doesn't seem to run properly still. It may be easier to debug further though with the modifications I made...

jsiegle commented 4 years ago

No worries. The tests were originally designed to use a local data cache, which is no longer working. The tests are in need of a complete overhaul, and it will be easier to debug with the simpler config file you wrote.

jsiegle commented 4 years ago

I just pushed some additional changes and the tests are running successfully now (albeit without any actual content).

mmyros commented 4 years ago

Nice, happy to help!