search

AllenInstitute / em_stitch

EM microscopy lens correction
BSD 2-Clause "Simplified" License
4 stars 3 forks source link

Serverless montage #24

Closed djkapner closed 5 years ago

pep8speaks commented 5 years ago

Hello @djkapner! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 77:1: E302 expected 2 blank lines, found 1

Line 186:9: E265 block comment should start with '# '

codecov-io commented 5 years ago

Codecov Report

Merging #24 into develop will increase coverage by 13.77%. The diff coverage is 97.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #24       +/-   ##
============================================
+ Coverage     58.5%   72.28%   +13.77%     
============================================
  Files           13       11        -2     
  Lines         1405      837      -568     
============================================
- Hits           822      605      -217     
+ Misses         583      232      -351
Impacted Files Coverage Δ
on_scope/utils/upload_montage.py 0% <ø> (ø)
on_scope/utils/fix_filepaths.py 0% <ø> (ø)
on_scope/utils/utils.py 76.59% <ø> (ø)
on_scope/utils/example_render_viz.py 0% <ø> (ø)
on_scope/utils/view_matches.py 0% <0%> (ø)
..._scope/lens_correction/mesh_and_solve_transform.py 89.14% <100%> (ø)
on_scope/lens_correction/schemas.py 100% <100%> (ø)
on_scope/lens_correction/lens_correction_solver.py 98.26% <100%> (ø)
on_scope/utils/schemas.py 100% <100%> (ø)
...scope/utils/generate_EM_tilespecs_from_metafile.py 93.61% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b608d0...e16239b. Read the comment docs.