Adding response df - Githubissues

AllenInstitute / mindscope_utilities

Utilities for loading, manipulating and visualizing data from the Allen Institute Mindscope program

Other

2 stars 1 forks source link

Adding response df #28

Closed yavorska-iryna closed 3 years ago

yavorska-iryna commented 3 years ago

adding:

get_event_timestamps
get_stimulus_response_xr
compute_means_xr

yavorska-iryna commented 3 years ago

this branch still needs documentations for compute_means_xr, and tests for all three functions

dougollerenshaw commented 3 years ago

Looks good. I like having these functions here, rather than at the top level.

I'd also suggest writing tests for these functions, but since time is limited right now before Friday Harbor, it makes sense to go ahead and merge these to master, then add the tests in a later PR.

dougollerenshaw commented 3 years ago

Also, before merging you'll want to update the version from 0.1.7 to 0.1.8 here: https://github.com/AllenInstitute/mindscope_utilities/blob/7725c4b83b66fbd52d74cd4adf17d1cacc616fad/setup.py#L4 and here: https://github.com/AllenInstitute/mindscope_utilities/blob/7725c4b83b66fbd52d74cd4adf17d1cacc616fad/mindscope_utilities/__init__.py#L4

This will ensure that we have a unique version to push to pypi.