AllenInstitute / neuroglia

a Python machine learning library for neurophysiology data
http://neuroglia.readthedocs.io
BSD 3-Clause "New" or "Revised" License
36 stars 7 forks source link

more deconvolution tests #100

Closed j-friedrich closed 6 years ago

j-friedrich commented 6 years ago

some more tests for better coverage

codecov-io commented 6 years ago

Codecov Report

Merging #100 into master will increase coverage by 10.15%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #100       +/-   ##
===========================================
+ Coverage   67.09%   77.25%   +10.15%     
===========================================
  Files          14       14               
  Lines         699      699               
===========================================
+ Hits          469      540       +71     
+ Misses        230      159       -71
Impacted Files Coverage Δ
neuroglia/calcium/oasis/functions.py 66.03% <0%> (+22.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13017e9...3387a2a. Read the comment docs.

mochic commented 6 years ago

@j-friedrich can we use your values in the tests ive added in #94?

j-friedrich commented 6 years ago

Noticed your PR too late, hence retracted mine. Yes, should be fine to use these values.

On Wed, Apr 25, 2018 at 1:42 PM, mochic notifications@github.com wrote:

@j-friedrich https://github.com/j-friedrich can we use your values in the tests ive added in #94 https://github.com/AllenInstitute/neuroglia/pull/94?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AllenInstitute/neuroglia/pull/100#issuecomment-384373051, or mute the thread https://github.com/notifications/unsubscribe-auth/ALU0aCq6ZsE35F_gdUfJVqJbJSsYJ8k_ks5tsLV-gaJpZM4TjxCS .

mochic commented 6 years ago

great thanks for helping us