Closed jeromelecoq closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
katrinaager commented on 2023-08-27T22:00:18Z ----------------------------------------------------------------
be more specific with "in the end", clarify what you mean by this and add a period for a full sentence
View / edit / reply to this conversation on ReviewNB
katrinaager commented on 2023-08-27T22:00:19Z ----------------------------------------------------------------
Line #49. nb_repeat = len(cebra_time_model_list)
From this line through the rest of the cell, I would perhaps put this in a cell of its own and give a caption explaining what is going on. I see you give a description after, but I might introduce what a KNN decoder is. Maybe describe what a "fold" is with more clarity. I wouldn't say these descriptions are absolutely necessary, but they could contribute to user understanding. I think it could benefit from breaking the above cell into 2 different cells though.
View / edit / reply to this conversation on ReviewNB
katrinaager commented on 2023-08-27T22:00:20Z ----------------------------------------------------------------
I think this graph should be explained in more detail. Reference specific things within the graph for beginner users.
I just added 3 comments using ReviewNB :)
This: