search

AllenInstitute / openscope_databook

OpenScope databook: a collaborative, versioned, data-centric collection of foundational analyses for reproducible systems neuroscience 🐁🧠🔬🖥️📈
https://alleninstitute.github.io/openscope_databook
Other
62 stars 19 forks source link

Fix erroneous test workflows? #337

Closed rcpeene closed 6 months ago

rcpeene commented 7 months ago

Had some strange behavior with a build workflow failing on a file even though the prior test succeeded. The line that was the reported cause of the error seemed to be using a different version of the file that was not the latest.

It is probably because the build test is setup improperly. Must investigate.

rcpeene commented 6 months ago

I think I was misled; the tests run fun as they are. I must have mistakenly pushed a commit to main that did not pass tests, which then made all subsequent build runs on main. In other words, if main is put into a position where it fails tests, then all PR build tests into main will fail.

jeromelecoq commented 6 months ago

This worked recently. Let's close unless it reappears