search

AllenInstitute / openscope_databook

OpenScope databook: a collaborative, versioned, data-centric collection of foundational analyses for reproducible systems neuroscience 🐁🧠🔬🖥️📈
https://alleninstitute.github.io/openscope_databook
Other
62 stars 19 forks source link

Glm #353

Closed rcpeene closed 5 months ago

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2024-02-29T19:19:56Z ----------------------------------------------------------------

1/ We should cite our sources there. Maybe cite the pages you used to draft this notebook.

2/ Isn't Pillow using GLMs and GLM to distinguish between the two. It might be worth explaining what is different between those two.

3/ Can you explain the design matrix a bit more?


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2024-02-29T19:19:57Z ----------------------------------------------------------------

Is the key relevant here?


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2024-02-29T19:19:58Z ----------------------------------------------------------------

CIte source

I think we modified NeuroMatch code to add lam, we should say so.


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2024-02-29T19:19:59Z ----------------------------------------------------------------

It might be worth showing an average of many runs to make it easier to relate the model with the stimulus.


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2024-02-29T19:20:00Z ----------------------------------------------------------------

Turn interpolation off for imshow, that will be less confusing.


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2024-02-29T19:20:01Z ----------------------------------------------------------------

Missing y axis label, What is this plot for?


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2024-02-29T19:20:02Z ----------------------------------------------------------------

Great plot!

I would move the interpretation of it UNDER the plot for ease of read.


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

jeromelecoq commented on 2024-02-29T19:20:03Z ----------------------------------------------------------------

We should finish on a stronger biology note.

Select the top r2 cells, discuss what you see and maybe compare with other ways to select responsive cells.


  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.