search

AllenInstitute / openscope_databook

OpenScope databook: a collaborative, versioned, data-centric collection of foundational analyses for reproducible systems neuroscience 🐁🧠🔬🖥️📈
https://alleninstitute.github.io/openscope_databook
Other
59 stars 18 forks source link

Review: suggestions for "First-order analysis" section #397

Closed stephprince closed 3 weeks ago

stephprince commented 1 month ago

Here are my suggestions for the first-order analysis section! I think if I open the PR with these changes first, I should be able to make more general suggestions in the review notebook app. I will try to add them there, but let me know if you prefer I make an issue like I did for the other sections.

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rcpeene commented 1 month ago

These comments have all been addressed now and pushed to the scientific_review branch, In order to get it pass the build, could you pull the latest commits from scientific_review?

stephprince commented 1 month ago

@rcpeene Just merged the latest commits from scientific_review into this branch - let me know if you meant something else