Update ophys suite2p keys for LIMS

AllenInstitute / ophys_etl_pipelines

Pipelines and modules for processing optical physiology data

Other

9 stars 5 forks source link

Update ophys suite2p keys for LIMS #107

Closed wbwakeman closed 4 years ago

wbwakeman commented 4 years ago

It would be ideal to update the names of keys in input json file provided by the ophys_suite_2p_strategy.

Tasks:

[x] Update the names of schema in ophys_etl (see attached PR)
[x] Create Jira ticket for LIMS work: http://jira.corp.alleninstitute.org/browse/PBS-2521
[x] Update the ophys_suite_2P LIMS strategy to match and associated tests
[x] Wait for LIMS deployment (11/12)
[x] Update ophys_etl module (merge to main and watch CI work)

Validation criteria:

[x] Verify that updated strategy and module are working as expected

djkapner commented 4 years ago

This class should be renamed something related to Postprocessing. "convert" is not broad enough for its functionality.
This instance of that class should also be renamed to something like postproceesing. This is a user-facing name. Changing this name is what requires changing the LIMS strategy.

njmei commented 4 years ago

@djkapner It looks like you already made the changes needed in: https://github.com/AllenInstitute/ophys_etl_pipelines/pull/96/files ?

Since we aren't actively using the ophys_suite2p_queue in production it's probably safe to merge the changes?

njmei commented 4 years ago

ophys_etl_pipelines has been merged and docker image has been updated. If OPHYS_SUITE2P_QUEUE jobs fail, then need to change the input.json convert_args field name to postprocess_args.

Validation: