Consider renaming DenseROISchema and DenseROI TypedDict

AllenInstitute / ophys_etl_pipelines

Pipelines and modules for processing optical physiology data

Other

9 stars 5 forks source link

Closed njmei closed 4 years ago

njmei commented 4 years ago

Isaak brought up that the naming for the DenseROISchema and DenseROI TypedDict might be a bit confusing.

In the interests of rapid progress for the upcoming demo, we agreed to put off the renaming discussion.

Acceptance criteria:

[ ] Pika devs agree on appropriate names for the binarizer output schema (classifier input schema) and ROI TypedDict name
[ ] New names (if applicable) are updated

djkapner commented 4 years ago

@njmei I'm ok with closing this and leaving the names as is. What do you think?

njmei commented 4 years ago

@djkapner Also sounds fine to me. I'm going to go ahead and close this then.