Closed danielsf closed 1 year ago
Merging #544 (4dd09f9) into main (9a48db7) will decrease coverage by
1.36%
. The diff coverage is96.29%
.
@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 97.95% 96.59% -1.37%
==========================================
Files 107 106 -1
Lines 8159 8186 +27
Branches 731 732 +1
==========================================
- Hits 7992 7907 -85
- Misses 97 207 +110
- Partials 70 72 +2
Flag | Coverage Δ | |
---|---|---|
event_detection_tests | ? |
|
general_tests | 96.59% <96.29%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...scope_splitting_cli/test_mesoscope_splitter_1x6.py | 100.00% <ø> (ø) |
|
...scope_splitting_cli/test_mesoscope_splitter_2x4.py | 100.00% <ø> (ø) |
|
...ng_cli/test_mesoscope_splitter_2x4_with_repeats.py | 100.00% <ø> (ø) |
|
...scope_splitting_cli/test_mesoscope_splitter_4x2.py | 100.00% <ø> (ø) |
|
...plitting_cli/test_mesoscope_splitter_4x2_floats.py | 100.00% <ø> (ø) |
|
...ng_cli/test_mesoscope_splitter_4x2_with_repeats.py | 100.00% <ø> (ø) |
|
tests/modules/mesoscope_splitting_cli/conftest.py | 96.65% <96.00%> (-0.19%) |
:arrow_down: |
...dules/mesoscope_splitting/test_full_field_utils.py | 100.00% <100.00%> (ø) |
|
.../modules/mesoscope_splitting/test_roi_insertion.py | 97.93% <100.00%> (ø) |
|
tests/modules/mesoscope_splitting_cli/utils.py | 100.00% <100.00%> (ø) |
|
... and 5 more |
Turns out, I'm just implementing the logic now. I'll close this PR and re-open when it is ready.
This is a very trivial pull request. It just creates a placeholder for the path to the platform json file so that, as discussed in #535, we can then modify the ruby strategy to provide the path to the platform.json without breaking the production pipeline.
Once this has been merged and the ruby strategy has been updated, we can add the logic to use the contents of platform.json to generate the stitched full field images being requested by the ophys team.