AllenInstitute / ophys_etl_pipelines

Pipelines and modules for processing optical physiology data
Other
9 stars 5 forks source link

Various DFF Fixes #552

Closed mikejhuang closed 1 year ago

mikejhuang commented 1 year ago

Addresses ticket https://github.com/AllenInstitute/ophys_etl_pipelines/issues/537

  1. Change kernel mode from constant to reflect
  2. Update baseline calculation such that median filter is only applied over "inactive frames"
  3. Remove detrending
codecov[bot] commented 1 year ago

Codecov Report

Merging #552 (a45c54f) into main (c9d61f8) will decrease coverage by 1.37%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   97.66%   96.29%   -1.37%     
==========================================
  Files         101      101              
  Lines        8040     8053      +13     
  Branches      764      764              
==========================================
- Hits         7852     7755      -97     
- Misses        109      219     +110     
  Partials       79       79              
Flag Coverage Δ
event_detection_tests ?
general_tests 96.29% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/modules/dff/test_dff.py 97.43% <100.00%> (+0.66%) :arrow_up:
tests/utils/test_traces.py 100.00% <100.00%> (ø)
tests/modules/event_detection/conftest.py 28.00% <0.00%> (-72.00%) :arrow_down:
...es/event_detection/test_event_detection_schemas.py 30.35% <0.00%> (-69.65%) :arrow_down:
...ts/modules/event_detection/test_event_detection.py 30.90% <0.00%> (-69.10%) :arrow_down:
...ules/event_detection/test_event_detection_utils.py 37.50% <0.00%> (-62.50%) :arrow_down: