AllenInstitute / ophys_etl_pipelines

Pipelines and modules for processing optical physiology data
Other
9 stars 5 forks source link

Add neuropil_correction module and update unconverged r vals #558

Closed mikejhuang closed 1 year ago

mikejhuang commented 1 year ago

Tickets addressed PSB-47 and PSB-72 https://github.com/AllenInstitute/ophys_etl_pipelines/issues/538

Summary

  1. Migrated neuropil correction module from AllenSDK to ophys_etl
  2. Add docstring and typing to functions
  3. Removed unused functions
  4. Added function to fill unconverged r values with mean r values from other cells of the same experiment
  5. Added tests
codecov[bot] commented 1 year ago

Codecov Report

Merging #558 (a4ecd79) into main (65bf64b) will increase coverage by 1.52%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   96.15%   97.68%   +1.52%     
==========================================
  Files         101      103       +2     
  Lines        7757     8123     +366     
  Branches      764      766       +2     
==========================================
+ Hits         7459     7935     +476     
+ Misses        219      109     -110     
  Partials       79       79              
Flag Coverage Δ
event_detection_tests 19.98% <37.14%> (?)
general_tests 96.33% <100.00%> (+0.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...opil_correction/test_neuropil_correction_runner.py 100.00% <100.00%> (ø)
...ropil_correction/test_neuropil_correction_utils.py 100.00% <100.00%> (ø)

... and 81 files with indirect coverage changes