AllenInstitute / ophys_etl_pipelines

Pipelines and modules for processing optical physiology data
Other
9 stars 5 forks source link

Add Demix module #560

Closed mikejhuang closed 1 year ago

mikejhuang commented 1 year ago
  1. Migrate demix module from AllenSDK to ophys_etl_pipelines
  2. Set up schemas in the standard of ophys_etl
  3. Write test for job runner cli
  4. Add typing + docstring and remove unused functions in demixer
  5. A few code refactors for unnecessary logic
mikejhuang commented 1 year ago

One of the tests is failing due to the order of the running tests. When I run flake8 on that individual test file test_demixer, it passes. But when I run flake8 on the demix test directory in tests/modules/demix, it fails.

I'm trying to see what's not being torn down that can lead to this issue.

codecov[bot] commented 1 year ago

Codecov Report

Merging #560 (63044d1) into main (09c00d5) will decrease coverage by 1.44%. The diff coverage is 89.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   97.69%   96.26%   -1.44%     
==========================================
  Files         103      105       +2     
  Lines        8130     8221      +91     
  Branches      767      769       +2     
==========================================
- Hits         7943     7914      -29     
- Misses        109      229     +120     
  Partials       78       78              
Flag Coverage Δ
event_detection_tests ?
general_tests 96.26% <89.01%> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/modules/demix/test_demix_job.py 84.84% <84.84%> (ø)
tests/modules/demix/test_demixer.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes