AllenInstitute / ophys_etl_pipelines

Pipelines and modules for processing optical physiology data
Other
9 stars 5 forks source link

Danielsf/make/ff/optional #565

Closed danielsf closed 1 year ago

danielsf commented 1 year ago

Full field image generation has been stumbling over some edge cases in the data. Our users do not want a failure in this last step of TIFF splitting to fail an entire TIFF splitting job. This PR wraps the full field image generation step in a try/except block such that failure of that step does not fail the whole job. However, the traceback resulting from full field image failure will be written to the log, so that we can double back and debug the failure, should we so choose.

codecov[bot] commented 1 year ago

Codecov Report

Merging #565 (8d4fb1a) into main (8d4ae5d) will decrease coverage by 1.34%. The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   97.60%   96.27%   -1.34%     
==========================================
  Files         105      105              
  Lines        8239     8249      +10     
  Branches      772      775       +3     
==========================================
- Hits         8042     7942     -100     
- Misses        119      229     +110     
  Partials       78       78              
Flag Coverage Δ
event_detection_tests ?
general_tests 96.27% <90.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/modules/mesoscope_splitting_cli/conftest.py 96.59% <87.50%> (+0.07%) :arrow_up:
...mesoscope_splitting_cli/test_mesoscope_splitter.py 92.50% <100.00%> (+0.12%) :arrow_up:

... and 4 files with indirect coverage changes