psb-116 Calculate `is_in_motion_border` flag in segmentation, remove is_small_size

AllenInstitute / ophys_etl_pipelines

Pipelines and modules for processing optical physiology data

Other

9 stars 5 forks source link

psb-116 Calculate `is_in_motion_border` flag in segmentation, remove is_small_size #582

Closed aamster closed 1 year ago

aamster commented 1 year ago

Calculate is_in_motion_border flag in segmentation
remove is_small_size (not used)
motion_border property returns MotionCorrectionRun, add to_dict method pass ophys_experiment_id to additional_steps

aamster commented 1 year ago

What's the reason you decided to calculate the motion border exclusion in these workflows vs passing the CSV file to letting the segmentation code handle it

the reason is that we already store the motion border in the db in the motion correction step. there are multiple differing implementations of determining the motion border and whether an roi is in the motion border in the ophys etl codebase. I don't want to be in a situation where the segmentation output differs from our own calculation using the motion border that we store