Closed mikejhuang closed 11 months ago
@mikejhuang I need to see that the tests are passing. Linting errors are blocking the tests from running. Please fix the linting errors so I can see that the tests are passing.
@mikejhuang I need to see that the tests are passing. Linting errors are blocking the tests from running. Please fix the linting errors so I can see that the tests are passing.
Are you sure? Won't this make it difficult for you to read the diff? Here are the workflow tests passing with an on prem machine (Synapse)
Alternatively, there might be a way to find all classes that end with
Module
and call.inputs
for each class as a smoke test. That way the schema will be automatically checked for each module.
Presently there aren't any tests for
denoising
roi_classification
trace_processing
Given that this was supposed to be a 3 point ticket (notwithstanding the extra work for the other ticket that came out of this), I didn't think creating the unit tests would be in the scope of this ticket. It would be caught in the integration tests that we decided to delegate much of the testing to.
@mikejhuang what you outlined above was supposed to be the purpose of this ticket. If there are things that can be tested then they should be tested rather than leaving it up to manual testing. If you need to increase the point count to work on it then please do it
PipelineModule
, that requires pipeline module classes to be created with an argschema object