AllenInstitute / ophys_etl_pipelines

Pipelines and modules for processing optical physiology data
Other
9 stars 5 forks source link

Ticket/psb-183: Remove start/end frame, motion correction reset. #599

Closed morriscb closed 1 year ago

morriscb commented 1 year ago

Experiments were found that, while they don't have empty data for there initial ophys movie frames (as was the case for some experiments in SSF where the shutter was closed for the initial N frames), they have a different/low enough intensity to trigger the code to detect shutter closed frames. Reworked the code to throw a warning rather than resetting frames that are detected in this way. Reworked/worded log output to warn when these cases, remove them from consideration when computing a reference image, and mark the frames in the output CSV file.

codecov[bot] commented 1 year ago

Codecov Report

Merging #599 (e3990a9) into main (baf85d9) will not change coverage. The diff coverage is n/a.

:exclamation: Current head e3990a9 differs from pull request most recent head 7a79945. Consider uploading reports for the commit 7a79945 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         105      105           
  Lines        8249     8249           
  Branches      775      775           
=======================================
  Hits         8052     8052           
  Misses        119      119           
  Partials       78       78           
Flag Coverage Δ
event_detection_tests 20.02% <ø> (ø)
general_tests 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...registration/test_suite2p_registration_pipeline.py 98.80% <ø> (ø)