adds more detail to logging

[djkapner]

2 changes:

• when a pariwise registration fails, this writes a file to disk and logs it. This will make it easier for processing support to look at particular failures:

  INFO:PairwiseMatching:Matching 929655728 to 938002077: best registration was ['Identity']
  INFO:PairwiseMatching:Matching 930996073 to 935514366
  WARNING:PairwiseMatching:Matching 929655728 to 938002077: no registration found. wrote /home/danielk/tmp/avg_projections_929655728_938002077_20201123151906.png

  and the image for that looks like:

• raising an exception for pairwise registration failures has been deferred to nway matching. This allows all registrations to be attempted and a summary matrix to be logged. Again, this is for making processing support for failures easier.

  INFO:NwayMatching:registration success(1) or failure (0):
  0  1  2  3  4  5  6  7  8
  0  1  0  1  0  0  0  0  0  0
  1  0  1  1  1  1  1  1  1  1
  2  1  1  1  1  1  1  1  1  1
  3  0  1  1  1  1  1  1  1  1
  4  0  1  1  1  1  1  1  1  1
  5  0  1  1  1  1  1  1  1  1
  6  0  1  1  1  1  1  1  1  1
  7  0  1  1  1  1  1  1  1  1
  8  0  1  1  1  1  1  1  1  1
  id map{
  "0": 929655728,
  "1": 930996073,
  "2": 932372705,
  "3": 935514366,
  "4": 936500611,
  "5": 938002077,
  "6": 939471278,
  "7": 940433470,
  "8": 943518716
  }
  Traceback (most recent call last):
  File "/home/danielk/miniconda3/envs/nway38/lib/python3.8/runpy.py", line 194, in _run_module_as_main
  return _run_code(code, main_globals, None,
  File "/home/danielk/miniconda3/envs/nway38/lib/python3.8/runpy.py", line 87, in _run_code
  exec(code, run_globals)
  File "/home/danielk/repos/ophys_nway_matching/nway/nway_matching.py", line 433, in <module>
  nmod.run()
  File "/home/danielk/repos/ophys_nway_matching/nway/nway_matching.py", line 410, in run
  raise NwayException("not all pairwise registrations succeeded.")
  __main__.NwayException: not all pairwise registrations succeeded.

  in this case, from just the log, we can be pretty suspicious of experiment 929655728.

[codecov-io]

Codecov Report

Merging #58 (a00b496) into main (1462a02) will decrease coverage by 0.78%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   99.25%   98.46%   -0.79%     
==========================================
  Files           9        9              
  Lines         800      845      +45     
==========================================
+ Hits          794      832      +38     
- Misses          6       13       +7     

Impacted Files	Coverage Δ
nway/pairwise_matching.py	95.54% <30.00%> (-3.79%)	:arrow_down:
nway/nway_matching.py	96.82% <75.00%> (-0.48%)	:arrow_down:
nway/utils.py	100.00% <100.00%> (ø)