Closed pickles-bread-and-butter closed 4 years ago
Merging #102 into master will increase coverage by
0.22%
. The diff coverage is96.29%
.
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 90.53% 90.75% +0.22%
==========================================
Files 11 12 +1
Lines 581 606 +25
==========================================
+ Hits 526 550 +24
- Misses 55 56 +1
Impacted Files | Coverage Δ | |
---|---|---|
slapp/transforms/image_utils.py | 94.44% <94.44%> (ø) |
|
slapp/transforms/transform_pipeline.py | 91.86% <100.00%> (+0.49%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 35c5055...a0a1d93. Read the comment docs.
Just an FYI I'm going to rebase away a couple of commits before addressing changes to clean up history. I'm also going to improve the PR overview, then circle back around to comments.
LGTM overall, I think it would be nice to see some images in the PR description.
I'll approve after fixing linting errors. I prefer the overload, but it doesn't need to hold up the PR. For the full pipeline I think we should move the scale up and to the right a few pixels. It looks too close to the edge IMO on the images you showed.
Please update your commit history prior to merging. The headers are not informative atm. You can squash where it makes sense.
Please update your commit history prior to merging. The headers are not informative atm. You can squash where it makes sense.
I rebased away the intermediate commits and left the one additional change Dan requested.
Overview
This commit adds a scale onto the bottom of images and videos so that users have a better idea of the size of objects in view for more informed labeling. Added a new module, image_utils.py, to hold the add_scale function. Add scale_function adds a scale of user specified size in microns to the bottom of a supplied image. Transformation pipeline was updated to make use of this function to add scales to outline masks, in full and sub-sampled views. The testing functions were updated to work with this change.
Adds
Validation
Full ROI Mask Outline Image with Scale
Subset ROI Mask Outline Image with Scale
Sagemaker GT Screenshots
Sagemaker GT Job Link
Ground Truth Job